Skip to content

Fix Regression: interpreter selection status bar not working when switching environments #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StellaHuang95 wants to merge 1 commit into from
Closed

Fix Regression: interpreter selection status bar not working when switching environments #1126

StellaHuang95 wants to merge 1 commit into from
+65 −26

Conversation

@StellaHuang95
Copy link
Contributor

@StellaHuang95 StellaHuang95 commented Jan 28, 2026

fixes #1124

The changes made in #1120 introduced logic to avoid writing unnecessary settings when the selected environment manager is the implicit default (system manager). This was intended to prevent polluting settings.json.

However, this optimization broke manual interpreter selection. When a user clicks the status bar and explicitly selects a global/system interpreter in a workspace with an empty settings.json, the selection is silently ignored because the code determines "this is the default, so don't write it."

This PR added an optional forceWrite flag to EditAllManagerSettings, EditEnvManagerSettings, and EditPackageManagerSettings interfaces and updated all user-initiated callers in envManagers.ts and envCommands.ts to pass forceWrite: true.

image

@StellaHuang95 StellaHuang95 added the bug Issue identified by VS Code Team member as probable bug label Jan 30, 2026
@eleanorjboyd
Copy link
Member

eleanorjboyd commented Feb 2, 2026

thinking on this and the edge cases here- thanks for the PR

@StellaHuang95
Copy link
Contributor Author

StellaHuang95 commented Feb 2, 2026

thinking on this and the edge cases here- thanks for the PR

Thanks. Looking back at the original bug, the user reported that python-envs.defaultEnvManager: "ms-python.python:system" and python-envs.pythonProjects: [] were added to settings.json unexpectedly.

It seems reasonable to me that python-envs.defaultEnvManager gets added when an interpreter is selected for the workspace, based on the logic in settingHelper.ts. Would it make sense to check with Karthik whether this behavior is intentional? But I do agree that the logic around python-envs.pythonProjects could be improved so that the setting isn’t written when the value is empty.

@eleanorjboyd
Copy link
Member

eleanorjboyd commented Feb 3, 2026

ended up doing a larger overhaul since this needed area in general needed some work. Incorporated your PR improvements into here: #1155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

Assignees

No one assigned

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: interpreter selection status bar not working when switching environments

2 participants

@StellaHuang95 @eleanorjboyd